RFR: 8230398: Remove NULL checks before FREE_C_HEAP_ARRAY

Leo Korinth leo.korinth at oracle.com
Wed Sep 11 12:12:22 UTC 2019


Thanks for your review!

/Leo

On 11/09/2019 10:39, Thomas Schatzl wrote:
> Hi,
> 
> On 9/10/19 3:39 PM, Leo Korinth wrote:
>>
> [...]
>>>
>> I will remove NULL assignments of fields in destructors and keep them 
>> otherwise.
>>
>> I will also add a comment (// handles NULL pointers) to FreeHeap and 
>> os::free to not only describe behaviour, but also to establish a 
>> contract.
>>
>> Also fixed indentation miss in os_perf_windows.cpp
>>
>> Incremental:
>> http://cr.openjdk.java.net/~lkorinth/8230398/00_01
>>
>> Full:
>> http://cr.openjdk.java.net/~lkorinth/8230398/01
>>
>>
>> running tests...
> 
>    still looks good.
> 
> Thomas


More information about the hotspot-dev mailing list