RFR (L) JDK-8230505: Replace JVM type comparisons to T_OBJECT and T_ARRAY with call to is_reference_type

[Lois Foltan]

On 9/11/2019 12:35 PM, coleen.phillimore at oracle.com wrote:
> http://cr.openjdk.java.net/~lfoltan/bug_jdk8230505.0/webrev/src/hotspot/share/ci/ciConstant.cpp.udiff.html 
>
> http://cr.openjdk.java.net/~lfoltan/bug_jdk8230505.0/webrev/src/hotspot/share/classfile/bytecodeAssembler.cpp.udiff.html 
>
>
> Not sure if I agree with the changes to make is_reference_type() 
> called in the default label of a case statement.

Thanks Coleen for the review.  I too share your concern about calling 
is_reference_type in the default label of the case statement, however I 
plan to leave as-is because it does allow for future reference types 
like potentially valhalla inline types.

Lois

>
> Wow, there were a lot of these.  The rest of the change looks great.
>
> Thanks,
> Coleen
>
>
> On 9/11/19 11:29 AM, Lois Foltan wrote:
>> Please review the following change to call is_reference_type() when 
>> checking if a type is a T_OBJECT or a T_ARRAY.
>>
>> open webrev at: 
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8230505.0/webrev/index.html
>> bug link: https://bugs.openjdk.java.net/browse/JDK-8230505
>>
>> Builds: all tier1 builds, did build with Shenandoah GC, and Solaris 
>> builds
>> Testing: hs-tier1-4 & jdktier1-2 (all platforms), hs-tier5-8 (linux-x64)
>>
>> Thanks,
>> Lois
>>
>>
>