[RFR] 8231171: remove remaining sun.java.launcher.pid references - was RE: sun.java.launcher.pid property usage

David Holmes david.holmes at oracle.com
Fri Sep 20 09:41:04 UTC 2019


That looks fine to me.

Thanks,
David

On 20/09/2019 7:14 pm, Baesken, Matthias wrote:
> Hi David   , I adjusted the  test  ( test/jdk/tools/launcher/TestSpecialArgs.java )   and removed the comments  in os_bsd.cpp  (suggested by you) .
> New webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8231171.1/
> 
> Best regards, Matthias
> 
> 
> 
> 
>> Hi Matthias,
>>
>> On 20/09/2019 5:03 pm, Baesken, Matthias wrote:
>>>
>>> Hello,  looks like   on Linux  there is a special check   in TestSpecialArgs.java
>> for
>>>
>>>       launcherPidString = "launcher.pid="
>>>
>>> that  fails after   8231171  .
>>> Should I adjust the test ?  Or  keep the  setting in the launcher on Linux ?
>>
>> IMHO adjust the test please.
>>
>> Thanks,
>> David
>> -----
>>
> 


More information about the hotspot-dev mailing list