[14] RFR(XS): 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment?

[David Holmes]

Looks good!

Thanks,
David
-----

On 23/09/2019 6:42 pm, Tobias Hartmann wrote:
> Hi David,
> 
> On 23.09.19 10:25, David Holmes wrote:
>> Functional change looks good. Thanks for explaining the history to me. :)
> 
> Thanks for the review!
> 
>> In the test do we generally use -XX:+IgnoreUnrecognizedVMOptions with develop flags or should we
>> @require a debug vm?
> 
> I've seen both but adding @requires is better in this case because the test is completely useless
> when executed with a product VM. Updated webrev:
> http://cr.openjdk.java.net/~thartmann/8231058/webrev.01/
> 
> Thanks,
> Tobias
>