RFR (M) JDK-8210012: Implement Unified Logging Option for -XX:+TraceMethodHandles and -XX:+TraceInvokeDynamic

John Rose john.r.rose at oracle.com
Thu Apr 9 21:03:28 UTC 2020


Reviewed.  Nice things I saw:

 - fewer uses of ttyLocker
 - indy-related diagnostics getting into UL
 - UL being strong enough to handle complex multi-line formatted output

Side comment about UL:  Last time I looked, which was a
while ago, UL was not friendly to multi-line outputs.

Eventually, UL should be applied to -XX:+LogCompilation, but
that will require UL to manage large structured segments of
logging data.  -XX:+LC produces a large XML-flavored report
for each distinct compilation task.

> On Apr 9, 2020, at 11:42 AM, Lois Foltan <lois.foltan at oracle.com> wrote:
> 
> Please review the following change to implement unified logging options for -XX:+TraceMethodHandles and -XX:+TraceInvokeDynamic. The new options map as follows:
> 
> -XX:+TraceMethodHandles --> -Xlog:methodhandles=info
> -XX:+TraceInvokeDynamic -->  -Xlog:methodhandles+indy=debug
> 
> and in addition dynamic constants can now be viewed under their own option via -Xlog:methodhandles+condy=debug
> 
> open webrev at: http://cr.openjdk.java.net/~lfoltan/bug_jdk8210012.0/webrev/
> bug link: https://bugs.openjdk.java.net/browse/JDK-8210012
> 
> Testing: hs-tier1-5
> 
> Thanks,
> Lois



More information about the hotspot-dev mailing list