RFR: 8240110: Improve NULL

[David Holmes]

Hi Leo,

Before I look at the webrev one query ..

<trimming>

On 14/04/2020 11:53 pm, Leo Korinth wrote:
> On 06/04/2020 01:37, David Holmes wrote:
>>> I could change CHECK_0 to use NULL_WORD though and if I do, I get 
>>> compiler errors. CHECK_0 is used for both pointers and integral 
>>> zeroes and types that implicitly converts from either. What the 
>>> original thought was is unclear to me; is CHECK_0 to be used to 
>>> return things convertible from pointers? If so, what is CHECK_NULL for?
>>
>> No CHECK_0 is intended for int-returning functions (which would also 
>> extend to intptr_t).
> 
> It might be intended for it, but it is not used in such a way (therefore 
> my remark on compile failures when using NULL_WORD)
> 
> I will do no change here.

Please explain what you mean by "it is not used in such a way". Other 
than a few misuses in ./share/jvmci/jvmciCompilerToVM.cpp where it is 
used for jboolean and the jobject case you are fixing, it is used in 
methods that return jint, jbyte, jlong ...

Thanks,
David
-----