RFR 8242931: Few more tests that use nashorn have been missed

Daniel Fuchs daniel.fuchs at oracle.com
Thu Apr 16 17:46:05 UTC 2020


Hi Sundar,

I spotted a typo (generial vs generic) test/jdk/ProblemList.txt:

  936 java/util/ServiceLoader/ReloadTest.java 
8242935 generial-all

This is not an area I know well - so maybe wait for at least
another opinion (reviewer or not) but what I saw looked
reasonable.

You have my review.

best regards,

-- daniel

On 16/04/2020 17:26, sundararajan.athijegannathan at oracle.com wrote:
> Please review updated webrev: 
> http://cr.openjdk.java.net/~sundar/8242931/webrev.01/
> 
> Thanks,
> 
> -Sundar
> 
> On 16/04/20 6:49 pm, David Holmes wrote:
>> +1 Please problem list the tests under the associated bug ids.
>>
>> Thanks,
>> David
>>
>> On 16/04/2020 11:10 pm, Alan Bateman wrote:
>>> On 16/04/2020 13:59, sundararajan.athijegannathan at oracle.com wrote:
>>>> Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript 
>>>> Engine) missed updating few tests, config files.
>>>>
>>>> Please review.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8242931
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/
>>>>
>>>> PS I'm disabling tests by adding @ignore. I've filed bugs for the 
>>>> tests. Please revisit port or remove these nashorn using tests
>>> Can you use the jtreg exclude lists (ProblemList.txt files) instead? 
>>> We moved away from @ignore a few ago to make it easier to track 
>>> excluded tests.
>>>
>>> -Alan





More information about the hotspot-dev mailing list