RFR: 8242626: enhance posix print_rlimit_info

[Baesken, Matthias]

Hi Gerard,  thanks for the review !

> output and I didn't find any, but did you run any tests just in case?

Yes I had the patch in our internal build/test queue (incl JCK/jtreg and others) , I did not notice any issues with the patch .

Best regards, Matthias


-----Original Message-----
From: gerard ziemski <gerard.ziemski at oracle.com> 
Sent: Donnerstag, 16. April 2020 17:53
To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Subject: Re: RFR: 8242626: enhance posix print_rlimit_info

hi Matthias,

Nice enhancement, I like that you added the hard limit and that we now 
check the return code.

+1 from me (small r reviewer)

ps. I checked our tests to see whether any one of them parses the rlimit 
output and I didn't find any, but did you run any tests just in case?


cheers

On 4/14/20 10:27 AM, Baesken, Matthias wrote:
> Please review this small enhancement of  os::Posix::print_rlimit_info.
>
> It adds  return code handling  of  getrlimit ,  output of some more limit values and  output of  hard limits (additionally to the existing soft limits) .
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8242626
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8242626.1/
>
> Thanks, Matthias