RFR (XS) JDK-8243045: AOTCompiledMethod::print_on triggers assertion after JDK-8210012

Lois Foltan lois.foltan at oracle.com
Mon Apr 20 19:53:26 UTC 2020


Thank you Coleen and Vladimir for your reviews!
Lois

On 4/20/2020 3:40 PM, Vladimir Kozlov wrote:
> +1
>
> Vladimir K
>
> On 4/20/20 11:59 AM, coleen.phillimore at oracle.com wrote:
>> +1.
>>
>> Coleen
>>
>> On 4/20/20 1:09 PM, Harold Seigel wrote:
>>> Looks good and trivial.
>>>
>>> Thanks, Harold
>>>
>>> On 4/20/2020 11:51 AM, Lois Foltan wrote:
>>>> Please review the following change to fix an issue when AOT and 
>>>> -Xlog:all=trace are specified together. This issue was found during 
>>>> hs-tier6 testing. AOTCompiledMethod::print_on() needs the same 
>>>> change that JDK-8210012 introduced for compiler/compileTask.cpp. 
>>>> The time stamp should come from tty, not the incoming outputStream 
>>>> parameter.
>>>>
>>>> open webrev at: 
>>>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8243045.0/webrev/
>>>> bug link: https://bugs.openjdk.java.net/browse/JDK-8243045
>>>>
>>>> Testing: hs-tier1  & hs-tier6 on all platforms, hs-tier1-7 linux only
>>>>
>>>> Thanks,
>>>> Lois
>>



More information about the hotspot-dev mailing list