RFR (M) Close alignment gaps in InstanceKlass

Ioi Lam ioi.lam at oracle.com
Thu Apr 23 16:43:58 UTC 2020


Hi Coleen,

The changes look good to me.

Thanks
- Ioi

On 4/21/20 1:12 PM, coleen.phillimore at oracle.com wrote:
> Summary: moved fields around and some constant fields into ConstantPool
>
> This is a simple change except that I moved some constant fields from 
> InstanceKlass into the constant pool so they can be shared read-only 
> in the CDS archive.  There are associated repercussions in SA and 
> JVMCI, so please look at these changes.  Also moved similarly sized 
> fields together in the class so there's less likelihood of introducing 
> gaps in future InstanceKlass changes.
>
> InstanceKlass is reduced from 544 to 520 bytes in a simple Hello World 
> class.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8238048.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8238048
>
> Tested with tier1-6.
>
> Thanks,
> Coleen
>
>



More information about the hotspot-dev mailing list