RFR(S): 8233014: Enable ShowCodeDetailsInExceptionMessages per default.

[David Holmes]

On 27/04/2020 7:49 pm, Reingruber, Richard wrote:
> Hi David, Goetz,
> 
>>> Just a minor detail: the license check fails for the file SuppressMessagesTest.java
>>>
>>> Try
>>>
>>>     sh make/scripts/lic_check.sh -gpl $(hg log -v --rev tip |sed -n '/files:[[:space:]]*/s///p')
> 
>> Why did it fail?
> 
> Because there is no match for make/templates/gpl-header I reckon.
> 
>>> With
>>>
>>> --- a/test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java
>>> +++ b/test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java
>>> @@ -1,6 +1,6 @@
>>>    /*
>>> + * Copyright (c) 2019, 2020, SAP SE. All rights reserved.
>>>     * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
>>> - * Copyright (c) 2019, 2020 SAP SE. All rights reserved.
>>>     * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>     *
>>>     * This code is free software; you can redistribute it and/or modify it
>>>
>>> it succeeds. Note that I added a comma after 2020 also.
> 
>> That doesn't seem to be the SAP format. (Though it is not 100% consistent.)
> 
> Right. In all files I checked the Oracle copyright line came before other copyright lines (SAP, Red
> Hat).

I was referring specifically to the comma after the second copyright 
year. It's an Oracle requirement, but not apparently a SAP one.

Most files with dual copyrights do have Oracle first, but that should 
not be a requirement for the header. There are many files without an 
Oracle copyright and if an Oracle engineer were to make significant 
changes and thus add the Oracle copyright, there's no rule I know that 
says the Oracle copyright should then come first. Sounds like a bug in 
the script to me.

Cheers,
David

> Maybe it is not applicable here?
> 
> Cheers, Richard.
> 
> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Montag, 27. April 2020 11:02
> To: Reingruber, Richard <richard.reingruber at sap.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR(S): 8233014: Enable ShowCodeDetailsInExceptionMessages per default.
> 
> On 27/04/2020 6:20 pm, Reingruber, Richard wrote:
>> Hi Goetz,
>>
>> Just a minor detail: the license check fails for the file SuppressMessagesTest.java
>>
>> Try
>>
>>     sh make/scripts/lic_check.sh -gpl $(hg log -v --rev tip |sed -n '/files:[[:space:]]*/s///p')
> 
> Why did it fail?
> 
>> With
>>
>> --- a/test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java
>> +++ b/test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java
>> @@ -1,6 +1,6 @@
>>    /*
>> + * Copyright (c) 2019, 2020, SAP SE. All rights reserved.
>>     * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
>> - * Copyright (c) 2019, 2020 SAP SE. All rights reserved.
>>     * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>     *
>>     * This code is free software; you can redistribute it and/or modify it
>>
>> it succeeds. Note that I added a comma after 2020 also.
> 
> That doesn't seem to be the SAP format. (Though it is not 100% consistent.)
> 
> Cheers,
> David
> 
>> Cheers, Richard.
>>
>> -----Original Message-----
>> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Lindenmaier, Goetz
>> Sent: Freitag, 24. April 2020 16:36
>> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>> Subject: RFR(S): 8233014: Enable ShowCodeDetailsInExceptionMessages per default.
>>
>> Hi,
>>
>> I would like to enable JEP 358 Helpful NullPointerExceptions by default:
>>
>> http://cr.openjdk.java.net/~goetz/wr19/8233014-enable_NPE_per_default/02/
>>
>> Please review.
>>
>> The change passed our testing and jdk-submit.
>>
>> Best regards,
>>    Goetz.
>>