RFR: 8242244: Remove redundant ELF machine definitions

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Tue Apr 28 10:38:04 UTC 2020


Hi Ao!

On 4/28/20 12:33 PM, Ao Qi wrote:
> It failed to build on my two linux x64 machines after this fix. They
> are Ubuntu 18.04.4(5.3.0-46-generic) and CentOS Linux release
> 8.1.1911(4.18.0-147.el8.x86_64). Should we add this patch:
> $ hg diff
> diff -r 7205265660b2 src/hotspot/os/linux/os_linux.cpp
> --- a/src/hotspot/os/linux/os_linux.cpp Tue Apr 28 05:53:19 2020 -0400
> +++ b/src/hotspot/os/linux/os_linux.cpp Tue Apr 28 18:24:45 2020 +0800
> @@ -110,6 +110,7 @@
>  # include <stdint.h>
>  # include <inttypes.h>
>  # include <sys/ioctl.h>
> +# include <linux/elf-em.h>
> 
>  #ifndef _GNU_SOURCE
>    #define _GNU_SOURCE

Apologies for the problem. I'm surprised that it failed because of EM_486
missing but not the other missing EM_ definitions.

Your change looks reasonable in any case.

@Dmitry: Does it fix the build for you as well?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the hotspot-dev mailing list