RFR [XS]: 8244196: adjust output in os_linux

David Holmes david.holmes at oracle.com
Thu Apr 30 23:31:05 UTC 2020


Hi Matthias,

On 1/05/2020 1:46 am, Baesken, Matthias wrote:
> Hello, please review this small change to os_linux.cpp  .
> 
> It  uses the  recently introduced    _print_ascii_file_h
> Function t more places (makes the code  a bit  shorter ) .

I like the intent here but I think we have lost a few newlines in the 
process. It isn't even clear to me that the result of print_ascii_file 
will end with a newline being printed. Can you check the before and 
after layout for readability please (and add to bug report).

Thanks,
David

> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8244196
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8244196.0/
> 
> Thanks, Matthias
> 


More information about the hotspot-dev mailing list