RFR (L) 8244997: Convert the JavaThread::_threadObj oop to use OopStorage

David Holmes david.holmes at oracle.com
Thu Aug 6 13:17:50 UTC 2020


Hi Coleen,

Thanks for all the work behind the scenes on checking the performance 
impacts of this (which for the record seem to be zero :)).

Can't comment on the details of the JIT changes but otherwise this all 
looks good to me. One typo below.

On 6/08/2020 10:40 pm, Coleen Phillimore wrote:
> Summary: Move the oop and handle releasing it in the service thread. 
> Remove Universe::oops_do from callers.
> 
> See bug for more details and discussion.  C2 code provided by Erik 
> Osterlund and Graal changes provided by Tom Rodriguez.
> 
> Tested with tiers 1-8.
> 
> bug link https://bugs.openjdk.java.net/browse/JDK-8244997
> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8244997.01/webrev

src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java

  // This substitution is no longer in used when threadObj is a handle

typo: s/used/use/  or s/in used/used/

Thanks,
David
-----

> Copyrights fixed, not in this webrev.
> 
> Thanks,
> Coleen


More information about the hotspot-dev mailing list