RFR: 8244801 - Code duplication in ReservedSpace::initialize/ReservedHeapSpace::try_reserve_heap
Cesar Soares Lucas
Divino.Cesar at microsoft.com
Thu Aug 6 21:30:58 UTC 2020
Bug: https://bugs.openjdk.java.net/browse/JDK-8244801
Webrev: https://cr.openjdk.java.net/~adityam/cesar/8244801/0/
Need sponsor: Yes
Can you please review the above linked patch for the mentioned bug?
It's a small change that refactor a portion of duplicated code in `virtualspace.cpp`.
I tried to structure the code so that the new code and the old printed the same
log messages. Please let me know if you want to simplify the method signature
and just hard code the log message. I also tried to come up with a short yet
descriptive name for the method; let me know if you have suggestions on that
as well.
Thanks,
Cesar
Software Engineer - Microsoft
More information about the hotspot-dev
mailing list