RFR (L) 8244997: Convert the JavaThread::_threadObj oop to use OopStorage

[Erik Österlund]

Hi Coleen,

Thanks for fixing the asserts. Looks good.

/Erik

> On 6 Aug 2020, at 20:39, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> 
> 
> 
>> On 8/6/20 10:39 AM, Coleen Phillimore wrote:
>> 
>> 
>>> On 8/6/20 9:45 AM, Erik Österlund wrote:
>>> Hi Coleen,
>>> 
>>> I think this looks good.
>>> 
>>> One nit. In the C1 code, the first load should be T_ADDRESS instead of T_METADATA.
>>> Don't need another webrev for that.
>> 
>> Thanks Erik.  I'll fix that.
> 
> Unfortunately, this change ran into an assert that I had to make accept T_ADDRESS.  After that c1 works fine.
> 
> http://cr.openjdk.java.net/~coleenp/2020/8244997.02.incr/webrev/index.html
> 
> Reran tier1 tests on Oracle platforms, and cross compiled on linux-arm32,linux-ppc64le-debug,linux-s390x-debug,linux-x64-zero.
> 
> Thanks,
> Coleen
> 
>> Coleen
>> 
>>> 
>>> Thanks,
>>> /Erik
>>> 
>>> On 2020-08-06 14:40, Coleen Phillimore wrote:
>>>> Summary: Move the oop and handle releasing it in the service thread. Remove Universe::oops_do from callers.
>>>> 
>>>> See bug for more details and discussion.  C2 code provided by Erik Osterlund and Graal changes provided by Tom Rodriguez.
>>>> 
>>>> Tested with tiers 1-8.
>>>> 
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8244997
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8244997.01/webrev
>>>> 
>>>> Copyrights fixed, not in this webrev.
>>>> 
>>>> Thanks,
>>>> Coleen
>>> 
>> 
>