[16] RFR(XS): 8252037: Optimized build is broken

[Vladimir Kozlov]

On 8/20/20 1:57 AM, Kim Barrett wrote:
>> On Aug 19, 2020, at 10:00 AM, Christian Hagedorn <christian.hagedorn at oracle.com> wrote:
>>
>> Hi
>>
>> Please review the following small patch which fixes the broken optimized build:
>> https://bugs.openjdk.java.net/browse/JDK-8252037
>> http://cr.openjdk.java.net/~chagedorn/8252037/webrev.00/
>>
>> There are actually two build issues as shown in the bug description.
>>
>> Thank you!
>>
>> Best regards,
>> Christian
> 
> I think the changes to parallelgc are contrary to the intent of the optimized build [1].  I think the
> bug here is that these counters are being conditionally printed under PRODUCT, but should
> be printed under ASSERT.  That is, 8232686 wasn’t quite right.  I guess nobody has done an
> optimized build in a while.
> 
> [1] Quoting myself from a different recent review thread:
> The purpose of "optimized" builds (as explained to me by one of its
> long-time proponents) is to have the performance characteristics of a
> release build (so no extra checks that affect performance or timing),
> but provide additional tools and data (printers, names, &etc) that we
> want to exclude from a release build for reasons of saving space or
> whatever. There's certainly lots of confusion around it though
I am still planning (when have a time) to work on:
https://bugs.openjdk.java.net/browse/JDK-8202283

Vladimir K