RFR: 8254733: HotSpot Style Guide should permit using range-based for loops

[Kim Barrett]

On Sat, 28 Nov 2020 06:37:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review and vote on this change to the HotSpot Style Guide to
> permit the use of range-based `for` loops in HotSpot code. Range-based
> `for` is a feature added in C++11.
> 
> This is a modification of the Style Guide, so rough consensus among
> the HotSpot Group members is required to make this change.  Only Group
> members should vote for approval (via the github PR), though reasoned
> objectsions or comments from anyone will be considered.  A decision on
> this proposal will not be made before Monday 7-Dec-2020 at 12h00 UTC.
> 
> Since we're piggybacking on github PRs here, please use the PR review
> process to approve (click on Review Changes > Approve), rather than
> sending a "vote: yes" email reply that would be normal for a CFV.
> Other responses can still use email of course.

> @kimbarrett
> 
> Not related to these changes which are fine.
> 
> I looked again on voting description for Style Guide changes. And it references to `rough consensus` which is not in OpenJDK bylaws :
> https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.html#L69
> 
> I think it is bug (separate from these changes) and should be fixed by using our rule http://openjdk.java.net/bylaws#three-vote-consensus
> With Project Lead final vote we will need at least 2 other members votes during 2 weeks review period. I think it is similar to `rough consensus`.

I'm going to move this discussion to a new thread in hotspot-dev.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1488