RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v5]
Thomas Stuefe
stuefe at openjdk.java.net
Tue Dec 1 20:34:09 UTC 2020
> To analyze JDK-8256729 further, we need more tracing:
>
> 1) We should print all mappings inside the split area if os::split_reserved_memory() fails
>
> 2) The print-mapping code on windows has some shortcomings:
> - should not probe for mappings outside of what we know are valid address ranges for Windows
> - should handle wrap-arounds - it should be possible to print the whole address space
> - Protection information is printed wrong (MEMORY_BASIC_INFORMATION.Protect would be the correct member)
> - should be printed in a more compact manner - base address should be on the same line as the first region
> - maybe adorned with some basic range info, e.g. library mappings
Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
Feedback Ioi
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1390/files
- new: https://git.openjdk.java.net/jdk/pull/1390/files/e2b71654..de705074
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=03-04
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1390.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1390/head:pull/1390
PR: https://git.openjdk.java.net/jdk/pull/1390
More information about the hotspot-dev
mailing list