RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v5]

Ioi Lam iklam at openjdk.java.net
Tue Dec 1 20:39:56 UTC 2020


On Tue, 1 Dec 2020 20:34:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> To analyze JDK-8256729 further, we need more tracing:
>> 
>> 1) We should print all mappings inside the split area if os::split_reserved_memory() fails
>> 
>> 2) The print-mapping code on windows has some shortcomings:
>> - should not probe for mappings outside of what we know are valid address ranges for Windows
>> - should handle wrap-arounds - it should be possible to print the whole address space
>> - Protection information is printed wrong (MEMORY_BASIC_INFORMATION.Protect would be the correct member)
>> - should be printed in a more compact manner - base address should be on the same line as the first region
>> - maybe adorned with some basic range info, e.g. library mappings
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback Ioi

Marked as reviewed by iklam (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1390


More information about the hotspot-dev mailing list