RFR: 8257563: Remove excessive include of klass.inline.hpp

Ioi Lam iklam at openjdk.java.net
Wed Dec 2 05:00:05 UTC 2020


klass.inline.hpp is unnecessarily included by two popular header files: oop.inline.hpp and modRefBarrierSet.inline.hpp

These two `#include` lines recursively pull in many header files. Removing them reduce the total number of header inclusion for building HotSpot from 260096 to 254773, or about 2%.

Notes to reviewer. The main changes are in the header files: 

* src/hotspot/share/classfile/systemDictionaryShared.hpp
* src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp
* src/hotspot/share/oops/instanceKlass.hpp
* src/hotspot/share/oops/instanceKlass.inline.hpp
* src/hotspot/share/oops/oop.inline.hpp

-------------

Commit messages:
 - 8257563: Remove excessive include of klass.inline.hpp

Changes: https://git.openjdk.java.net/jdk/pull/1552/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1552&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257563
  Stats: 276 lines in 83 files changed: 180 ins; 69 del; 27 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1552.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1552/head:pull/1552

PR: https://git.openjdk.java.net/jdk/pull/1552


More information about the hotspot-dev mailing list