RFR: 8257563: Remove excessive include of klass.inline.hpp

Thomas Stuefe stuefe at openjdk.java.net
Wed Dec 2 09:40:56 UTC 2020


On Wed, 2 Dec 2020 04:44:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> klass.inline.hpp is unnecessarily included by two popular header files: oop.inline.hpp and modRefBarrierSet.inline.hpp
> 
> These two `#include` lines recursively pull in many header files. Removing them reduce the total number of header inclusion for building HotSpot from 260096 to 254773, or about 2%.
> 
> Notes to reviewer. The main changes are in the header files: 
> 
> * src/hotspot/share/classfile/systemDictionaryShared.hpp
> * src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp
> * src/hotspot/share/oops/instanceKlass.hpp
> * src/hotspot/share/oops/instanceKlass.inline.hpp
> * src/hotspot/share/oops/oop.inline.hpp

LGTM. Thank you for doing this. My slow notebook thanks you.

..Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1552


More information about the hotspot-dev mailing list