RFR: JDK-8256864: [windows] Improve tracing for mapping errors [v6]

Thomas Stuefe stuefe at openjdk.java.net
Wed Dec 2 13:50:11 UTC 2020


> To analyze JDK-8256729 further, we need more tracing:
> 
> 1) We should print all mappings inside the split area if os::split_reserved_memory() fails
> 
> 2) The print-mapping code on windows has some shortcomings:
> - should not probe for mappings outside of what we know are valid address ranges for Windows
> - should handle wrap-arounds - it should be possible to print the whole address space
> - Protection information is printed wrong (MEMORY_BASIC_INFORMATION.Protect would be the correct member)
> - should be printed in a more compact manner - base address should be on the same line as the first region
> - maybe adorned with some basic range info, e.g. library mappings
> 
> Tested in our nightlies for a week now, works fine.
> 
> Example output see https://github.com/openjdk/jdk/files/5622718/mapping-printout.txt

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  Feedback Richard

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1390/files
  - new: https://git.openjdk.java.net/jdk/pull/1390/files/de705074..89b59069

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1390&range=04-05

  Stats: 22 lines in 3 files changed: 11 ins; 1 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1390.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1390/head:pull/1390

PR: https://git.openjdk.java.net/jdk/pull/1390


More information about the hotspot-dev mailing list