RFR: 8257563: Remove excessive include of klass.inline.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Wed Dec 2 23:27:17 UTC 2020


> klass.inline.hpp is unnecessarily included by two popular header files: oop.inline.hpp and modRefBarrierSet.inline.hpp
> 
> These two `#include` lines recursively pull in many header files. Removing them reduce the total number of header inclusion for building HotSpot from 260096 to 254773, or about 2%.
> 
> Notes to reviewer. The main changes are in the header files: 
> 
> * src/hotspot/share/classfile/systemDictionaryShared.hpp
> * src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp
> * src/hotspot/share/oops/instanceKlass.hpp
> * src/hotspot/share/oops/instanceKlass.inline.hpp
> * src/hotspot/share/oops/oop.inline.hpp

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8257563-remove-excessive-include-klass.inline.hpp
 - fixed ppc and x390 builds
 - Merge branch 'master' into 8257563-remove-excessive-include-klass.inline.hpp
 - 8257563: Remove excessive include of klass.inline.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1552/files
  - new: https://git.openjdk.java.net/jdk/pull/1552/files/96ce2128..1bd69389

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1552&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1552&range=00-01

  Stats: 1750 lines in 62 files changed: 1031 ins; 502 del; 217 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1552.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1552/head:pull/1552

PR: https://git.openjdk.java.net/jdk/pull/1552


More information about the hotspot-dev mailing list