Integrated: JDK-8256864: [windows] Improve tracing for mapping errors

Thomas Stuefe stuefe at openjdk.java.net
Thu Dec 3 08:44:57 UTC 2020


On Mon, 23 Nov 2020 15:26:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> To analyze JDK-8256729 further, we need more tracing:
> 
> 1) We should print all mappings inside the split area if os::split_reserved_memory() fails
> 
> 2) The print-mapping code on windows has some shortcomings:
> - should not probe for mappings outside of what we know are valid address ranges for Windows
> - should handle wrap-arounds - it should be possible to print the whole address space
> - Protection information is printed wrong (MEMORY_BASIC_INFORMATION.Protect would be the correct member)
> - should be printed in a more compact manner - base address should be on the same line as the first region
> - maybe adorned with some basic range info, e.g. library mappings
> 
> Tested in our nightlies for a week now, works fine.
> 
> Example output see https://github.com/openjdk/jdk/files/5622718/mapping-printout.txt

This pull request has now been integrated.

Changeset: b44a329f
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b44a329f
Stats:     143 lines in 4 files changed: 123 ins; 2 del; 18 mod

8256864: [windows] Improve tracing for mapping errors

Reviewed-by: iklam, rrich

-------------

PR: https://git.openjdk.java.net/jdk/pull/1390


More information about the hotspot-dev mailing list