RFR: JDK-8257588: Make os::_page_sizes a set [v2]

[Thomas Stuefe]

On Thu, 3 Dec 2020 12:26:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Not sure what you mean.
>> 
>> PagesizeSet::smallest() returns the smallest page in the page size set, which may be any size, or 0 if empty. 
>> 
>> os::_page_sizes should always contain os::vm_page_size(), but that too is not the same as os::min_page_size(). os::min_page_size() is just a constant, equal or smaller than the smallest page size across all platforms.
>> 
>> The naming is confusing, and probably it could be just a static const instead of a function. But I don't want to touch that with this change. But there are probably a number of misuses of os::min_page_size() where the author actually meant os::vm_page_size().
>
> Okay, apologies for falling into the mentioned trap.

No problem. We should probably improve this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522