RFR: 8257731: Remove excessive include of stubRoutines.hpp

Coleen Phillimore coleenp at openjdk.java.net
Fri Dec 4 00:12:58 UTC 2020


On Thu, 3 Dec 2020 23:20:33 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> stubRoutines.hpp is unnecessarily included by thread.hpp and copy.hpp. This causes a large number of header files related to native code generation to be included by almost all HotSpot .o files.
> 
> - Before the fix, stubRoutines.hpp is included by 803 .o files.
> - After the fix, stubRoutines.hpp is included by 117 .o files.
> 
> The total number of included header files decreased from 252893 to 247631, or about 2%.
> 
> Note: the main change is the removal of stubRoutines.hpp in thread.hpp and copy.hpp. Unfortunately I have to fix quite a few missing dependencies in other source files that are revealed by the removal.

Looks good to me, if you did a test build of zero and maybe ppc at least.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1610


More information about the hotspot-dev mailing list