RFR: 8252505: C1/C2 compiler support for blackholes [v23]

Aleksey Shipilev shade at openjdk.java.net
Fri Dec 4 09:26:59 UTC 2020


On Fri, 4 Dec 2020 09:17:47 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace fixes
>
> src/hotspot/share/compiler/compilerOracle.cpp line 418:
> 
>> 416:     } else {
>> 417:       ttyLocker ttyl;
>> 418:       tty->print_cr("Warning: blackhole compile command only works for methods with void type: %s",
> 
> It is printed unconditionally. What about guarding it with `!CompilerOracle::be_quiet()`?

As far as I can see, `CompilerOracle` prints warnings even with `quiet`. `quiet` seems to really only shun the successful messages. So this behavior is consistent. And frankly, it is a better UX: errors in compiler commands should be visible.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1203


More information about the hotspot-dev mailing list