RFR: JDK-8257588: Make os::_page_sizes a bitmask [v3]

Stefan Karlsson stefank at openjdk.java.net
Fri Dec 4 14:26:25 UTC 2020


On Thu, 3 Dec 2020 21:16:07 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback Thomas
>
> src/hotspot/share/runtime/os.cpp line 1859:
> 
>> 1857: bool os::PagesizeSet::is_set(size_t pagesize) const {
>> 1858:   assert(is_power_of_2(pagesize), "pagesize must be a power of 2: " INTPTR_FORMAT, pagesize);
>> 1859:   return (_v & pagesize) > 0;
> 
> Why is this `> 0` and not simply `!= 0`

I'm not sure if you saw this comment, but is there a reason why > 0 is used here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522


More information about the hotspot-dev mailing list