RFR: JDK-8257588: Make os::_page_sizes a bitmask [v4]

Thomas Stuefe stuefe at openjdk.java.net
Fri Dec 4 17:03:16 UTC 2020


On Fri, 4 Dec 2020 14:20:17 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback Stefan K
>
> test/hotspot/gtest/runtime/test_os.cpp line 625:
> 
>> 623:       }
>> 624:       ASSERT_EQ((size_t)0, pss.smallest());
>> 625:       ASSERT_EQ((size_t)0, pss.largest());
> 
> This doesn't have to be inside a double nested for loop. This could be single check done once.

I think I just remove it. Its pretty pointless, since we test for smallest=largest=0, and since we later test each bit individually in lines 645ff.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522


More information about the hotspot-dev mailing list