RFR: 8257731: Remove excessive include of stubRoutines.hpp

David Holmes david.holmes at oracle.com
Sun Dec 6 10:15:42 UTC 2020


On 5/12/2020 9:32 pm, Claes Redestad wrote:
> On Fri, 4 Dec 2020 17:00:57 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> 
>>> I have a suggestion: let's wait until JDK 16 forks for stabilization before we do any `#include` reshuffling? There are build breakages from these changes, so it would be nice to have these breakages away from the stabilizing repository.
>>
>>> I have a suggestion: let's wait until JDK 16 forks for stabilization before we do any `#include` reshuffling? There are build breakages from these changes, so it would be nice to have these breakages away from the stabilizing repository.
>>
>> OK, I'll push in JDK 17.
> 
>> With sufficient pre-integration testing this should not be an issue. It
>> seems for JDK-8257563 no GitHub actions were run and so numerous build
>> variants were missed.
> 
> And since there's likely going to be some churn happening in tandem in both mainline and stabilization fork in the coming weeks, wouldn't it be better to get changes like these pushed _before_ rather than right after the JDK 16 stabilization fork is created? The second best option might be to hold off with large cleanups/reshuffling until RDP2 starts.

I think the point was to defer to this to be 17 only so no churn at all 
in 16 RDP1 or RDP2.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1610
> 


More information about the hotspot-dev mailing list