RFR: 8257731: Remove excessive include of stubRoutines.hpp

Aleksey Shipilev shade at openjdk.java.net
Sun Dec 6 17:44:13 UTC 2020


On Sat, 5 Dec 2020 11:29:41 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>>> I have a suggestion: let's wait until JDK 16 forks for stabilization before we do any `#include` reshuffling? There are build breakages from these changes, so it would be nice to have these breakages away from the stabilizing repository.
>> 
>> OK, I'll push in JDK 17.
>
>> With sufficient pre-integration testing this should not be an issue. It
>> seems for JDK-8257563 no GitHub actions were run and so numerous build
>> variants were missed.
> 
> And since there's likely going to be some churn happening in tandem in both mainline and stabilization fork in the coming weeks, wouldn't it be better to get changes like these pushed _before_ rather than right after the JDK 16 stabilization fork is created? The second best option might be to hold off with large cleanups/reshuffling until RDP2 starts.

I don't mind pushing it for JDK 16. I was just suggesting that we defer somewhat intrusive cleanups to JDK 17, as it customary to do (at least in my vicinity) in order to have everyone else build/test based on clean master in the days coming to JDK 16 cutoff. But we could instead pay more attention to the state of master and fix the follow-up build failure bugs even more promptly this week.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1610


More information about the hotspot-dev mailing list