RFR: JDK-8256155: os::Linux Populate all large_page_sizes, select smallest page size in reserve_memory_special_huge_tlbfs* [v5]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Mon Dec 7 20:16:15 UTC 2020


On Mon, 7 Dec 2020 20:09:37 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:

>> Hi Marcus,
>> 
>> I generally like this patch. I will do a more thorough review later. But could this wait please until after JDK16 has been forked off? Since I would like this to spend some more times cooking on our more exotic Linuxes.
>> 
>> Cheers, Thomas
>
>> Hi Marcus,
>> 
>> I generally like this patch. I will do a more thorough review later. But could this wait please until after JDK16 has been forked off? Since I would like this to spend some more times cooking on our more exotic Linuxes.
>> 
>> Cheers, Thomas
> 
> Hi Thomas. I was pushing to get this patch in before JDK16 was forked.
> 
> Can we run exotic Linux tests now? Is there anything else keeping this from inclusion in JDK16?
> 
> As an aside, I will stand behind any patch I get upstream, including maintain it, discuss it or fix bugs.

I've resolved comments and merged so that changes from pull #1522 are no longer in the diff.

There are now only two files changed and a small amount of lines. I'd certainly appreciate any further detailed review or comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153


More information about the hotspot-dev mailing list