RFR: 8256424: Move ciSymbol::symbol_name() to ciSymbols::symbol_name()

[Ioi Lam]

On Tue, 17 Nov 2020 12:53:48 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> This moves the mirroring of vmSymbols in ciSymbols to a separate file, ciSymbols.hpp, to reduce includes throughout hotspot (and clean up the ciSymbol namespace). In a few places code is moved from .hpp to .cpp to facilitate this.
> 
> With PCH disabled, this reduces total includes from 276949 to 276332

Changes requested by iklam (Reviewer).

src/hotspot/share/ci/bcEscapeAnalyzer.hpp line 102:

> 100:   void compute_escape_info();
> 101:   vmIntrinsicID known_intrinsic();
> 102:   void compute_escape_for_intrinsic(vmIntrinsicID iid);

I think the use of vmIntrinsics::ID in bcEscapeAnalyzer.cpp should also be changed to vmIntrinsicID for consistency, even though they are the same type. (The same for other hpp files such as ciMethod.hpp)

src/hotspot/share/opto/library_call.cpp line 27:

> 25: #include "precompiled.hpp"
> 26: #include "asm/macroAssembler.hpp"
> 27: #include "ci/ciSymbols.hpp"

This file doesn't seem to use the exports from ciSymbols.hpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1256