RFR: 8257815: Replace global log2 functions with efficient implementations [v6]

Stefan Karlsson stefank at openjdk.java.net
Wed Dec 9 08:56:43 UTC 2020


On Wed, 9 Dec 2020 08:46:14 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   x->value
>
> test/hotspot/gtest/utilities/test_powerOfTwo.cpp line 266:
> 
>> 264: }
>> 265: 
>> 266: #define EXPECT_EQ_ILOG2(type)                                      \
> 
> Is there a reason why this is a macro and not a template function?

Ah, because you copied these tests. Maybe a future cleanup.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1663


More information about the hotspot-dev mailing list