RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT

[Coleen Phillimore]

Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug.  This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct).  There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.

Tested with tier1-3 with product and fastdebug builds.  Built with optimized.

This is for JDK 17.

-------------

Commit messages:
 - make crash test options develop options
 - 8252148: vmError::controlled_crash should be #ifdef ASSERT

Changes: https://git.openjdk.java.net/jdk/pull/1723/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1723&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252148
  Stats: 331 lines in 12 files changed: 141 ins; 165 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1723.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1723/head:pull/1723

PR: https://git.openjdk.java.net/jdk/pull/1723