RFR: 8257910: [JVMCI] Set exception_seen accordingly in the runtime. [v2]

[Vladimir Kozlov]

On Wed, 9 Dec 2020 23:06:47 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Update exception_seen flag in the MDO when no exception handler is found for caller during deoptimization, or when exception is thrown in the runtime.
>> 
>> Plus, `-Xlog:exceptions=info` code and `AbortVMOnException` are adjusted in C1 runtime and jvmci runtime to be consistent with C2, i.e., before `JvmtiExport::can_post_on_exceptions` deoptimization and fast continuation when compiled handler is found.
>
> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address comments.

Changes requested by kvn (Reviewer).

src/hotspot/share/jvmci/jvmciRuntime.cpp line 282:

> 280:   }
> 281:   // for AbortVMOnException flag
> 282:   NOT_PRODUCT(Exceptions::debug_check_abort(exception));

All other places calls debug_check_abort() in product too. It seems 8136577 changes missed JVMCI:
https://github.com/openjdk/jdk/commit/a25ce80e782a73390ae1109250dfa6fe6a48fcbe
Please, update to call it in product for JVMCI too. Note, AbortVMOnException is diagnostic flag now.

src/hotspot/share/c1/c1_Runtime1.cpp line 547:

> 545:     stringStream tempst;
> 546:     assert(nm->method() != NULL, "Unexpected NULL method()");
> 547:     tempst.print("compiled method <%s>\n"

Can you change message to?:
"C1 compiled method <%s>\n"

src/hotspot/share/jvmci/jvmciRuntime.cpp line 276:

> 274:     stringStream tempst;
> 275:     assert(cm->method() != NULL, "Unexpected null method()");
> 276:     tempst.print("compiled method <%s>\n"

Can you change message to?:
"JVMCI compiled method <%s>\n"

-------------

PR: https://git.openjdk.java.net/jdk/pull/1713