RFR: 8257731: Remove excessive include of stubRoutines.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Fri Dec 11 00:00:57 UTC 2020


On Sun, 6 Dec 2020 17:41:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> With sufficient pre-integration testing this should not be an issue. It
>>> seems for JDK-8257563 no GitHub actions were run and so numerous build
>>> variants were missed.
>> 
>> And since there's likely going to be some churn happening in tandem in both mainline and stabilization fork in the coming weeks, wouldn't it be better to get changes like these pushed _before_ rather than right after the JDK 16 stabilization fork is created? The second best option might be to hold off with large cleanups/reshuffling until RDP2 starts.
>
> I don't mind pushing it for JDK 16. I was just suggesting that we defer somewhat intrusive cleanups to JDK 17, as it customary to do (at least in my vicinity) in order to have everyone else build/test based on clean master in the days coming to JDK 16 cutoff. But we could instead pay more attention to the state of master and fix the follow-up build failure bugs even more promptly this week.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1610


More information about the hotspot-dev mailing list