Integrated: 8257731: Remove excessive include of stubRoutines.hpp

Ioi Lam iklam at openjdk.java.net
Fri Dec 11 00:00:59 UTC 2020


On Thu, 3 Dec 2020 23:20:33 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> stubRoutines.hpp is unnecessarily included by thread.hpp and copy.hpp. This causes a large number of header files related to native code generation to be included by almost all HotSpot .o files.
> 
> - Before the fix, stubRoutines.hpp is included by 803 .o files.
> - After the fix, stubRoutines.hpp is included by 117 .o files.
> 
> The total number of included header files decreased from 252893 to 247631, or about 2%.
> 
> Note: the main change is the removal of stubRoutines.hpp in thread.hpp and copy.hpp. Unfortunately I have to fix quite a few missing dependencies in other source files that are revealed by the removal.
> 
> Testing: I've tested tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.

This pull request has now been integrated.

Changeset: d4282b0c
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d4282b0c
Stats:     99 lines in 59 files changed: 73 ins; 10 del; 16 mod

8257731: Remove excessive include of stubRoutines.hpp

Reviewed-by: coleenp, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/1610


More information about the hotspot-dev mailing list