RFR: 8243205: Modularize JVM flags declaration [v3]

Ioi Lam iklam at openjdk.java.net
Fri Dec 11 03:39:07 UTC 2020


> This is the first step for modularizing the xxx_globals.hpp. The goals are
> 
> - Improve modularization of HotSpot source
> - Reduce JVM build time
> 
> To prove that this works,  I have moved compiler_globals.hpp outside of the monolithic globals.hpp. Before this fix, compiler_globals.hpp was included by 922 HotSpot .o files. After this fix, it's included by 283 .o files.
> 
> I plan to do more refactoring later, such as:
> 
> - move gc_globals.hpp out of globals.hpp
> - move the flags related to tiered compilation (about 40 flags) out of globals.hpp
> - move the platform-specific flags outside of globals.hpp
>   - these flags should be used only by platform-specific files. They shouldn't be used by shared files.
> 
> Note: this is target for JDK 17.
> 
> Testing: I've tested tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Merge branch 'master' into 8243205-modularize-globals-hpp
 - stefank comments
 - 8243205: Modularize global variable declaration for JVM flag macros

-------------

Changes: https://git.openjdk.java.net/jdk/pull/1608/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1608&range=02
  Stats: 494 lines in 27 files changed: 303 ins; 158 del; 33 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1608.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1608/head:pull/1608

PR: https://git.openjdk.java.net/jdk/pull/1608


More information about the hotspot-dev mailing list