RFR: 8234930: Use MAP_JIT when allocating pages for code cache on macOS [v7]

Anton Kozlov akozlov at openjdk.java.net
Fri Dec 11 13:42:58 UTC 2020


On Thu, 10 Dec 2020 21:17:59 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix style
>>  - JDK-8234930 v4: Use MAP_JIT when allocating pages for code cache on macOS
>>  - Revert "Separate executable_memory interface"
>>    
>>    This reverts commit 49253d8fe8963ce069f10783dcea5327079ba848.
>
> src/hotspot/os/linux/os_linux.cpp line 3275:
> 
>> 3273: struct bitmask* os::Linux::_numa_membind_bitmask;
>> 3274: 
>> 3275: bool os::pd_uncommit_memory(char* addr, size_t size, bool exec) {
> 
> nit: I'm irritated by `bool exec` in `pd_uncommit_memory`, but `bool executable` in `pd_reserve_memory`. Choose one :-)

Thanks, fixed. Too much of code shuffling. Now these should be consistent with the surroundings.

-------------

PR: https://git.openjdk.java.net/jdk/pull/294


More information about the hotspot-dev mailing list