RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v2]

[Coleen Phillimore]

On Fri, 11 Dec 2020 15:09:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/utilities/vmError.cpp line 1800:
>> 
>>> 1798:     case 2: guarantee(how == 0, "test guarantee"); break;
>>> 1799: 
>>> 1800:     // The other cases are unused.
>> 
>> I like that you cut down on the cases. Most of them were obsolete or not working correctly. 
>> 
>> How about compacting the cases? And maybe use a real enum. But this could also be done in a separate RFE.
>
> I thought it was kind of strange but then I didn't think it was worth the time to change it.  The command line processing doesn't have a way to pass enums through -XX:ErrorHandlerTest=plainSEGV or something like that. So in the end I didn't think it was something bad enough to change.
> 
> Answers above:  On my machine, the additional gtests add about 3 seconds to the run time where the gtests on the debug build take about a minute.  Since the gtests are thought to be a more efficient and direct testing mechanism, I don't think anyone's thought about ways to reduce the testing to account for performance.

Answered in conversation.  I couldn't really motivate the change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723