RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v3]

[Coleen Phillimore]

On Fri, 11 Dec 2020 07:27:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing va_end()
>
> test/hotspot/gtest/unittest.hpp line 138:
> 
>> 136:     ASSERT_EXIT(child_ ## category ## _ ## name ## _(),             \
>> 137:                 ::testing::ExitedWithCode(1),                       \
>> 138:                 "^assert failed: .*" msg);                          \
> 
> Good!

So if I take out '^' here, I've also fixed https://bugs.openjdk.java.net/browse/JDK-8257229 ?  I had a version without ^.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723