RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v3]

[Thomas Stuefe]

On Fri, 11 Dec 2020 18:21:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug.  This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct).  There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.
>> 
>> Tested with tier1-3 with product and fastdebug builds.  Built with optimized.
>> 
>> This is for JDK 17.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add missing va_end()

Thanks, looks good now.

..Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1723