RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v4]

[Coleen Phillimore]

On Fri, 11 Dec 2020 20:47:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> A better example for not adding the `.*` :  `TEST_VM_ASSERT_MSG(...., "a == true")` would incorrectly match `assert failed: !a == true`
>
> I reviewed your change.  There are 19 pre-existing tests that only want to test the message, which seems legitimate.

I fixed he other tests with a combination of adding the assert or adding a ".*" in front of the expected message.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723