RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest [v4]

[Thomas Stuefe]

On Fri, 11 Dec 2020 22:19:23 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed the ".*" in unittest.hpp and moved to the tests instead.
>
> Marked as reviewed by iklam (Reviewer).

Hi Coleen,

sorry, found another issue. In `print_error_for_unit_test` multiple threads may race and overwrite each others _detail_fmt buffer. Later on we block all threads but the first to report an error. But not here yet. So, maybe just use a C-heap allocated buffer or a stack buffer. I also don't think it has to be 1024, I guess 128 or so would be enough. We can make it larger if needed.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723