RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest [v6]

[Coleen Phillimore]

> Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug.  This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct).  There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.
> 
> Tested with tier1-3 with product and fastdebug builds.  Built with optimized.
> 
> This is for JDK 17.

Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:

 - Merge branch 'master' into crashtest
 - Make temporary detail message stack allocated.
 - Removed the ".*" in unittest.hpp and moved to the tests instead.
 - add missing va_end()
 - Fixed va_copy problem, and added changes from pull request.
 - make crash test options develop options
 - 8252148: vmError::controlled_crash should be #ifdef ASSERT

-------------

Changes: https://git.openjdk.java.net/jdk/pull/1723/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1723&range=05
  Stats: 362 lines in 18 files changed: 148 ins; 171 del; 43 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1723.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1723/head:pull/1723

PR: https://git.openjdk.java.net/jdk/pull/1723