RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest [v4]

[Coleen Phillimore]

On Mon, 14 Dec 2020 13:28:23 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi Thomas, thank you for finding the "last" bug in this.  I made the buffer stack allocated and 256. That should be enough and it passes all the gtests.  Thanks again.
>
>> Hi Thomas, thank you for finding the "last" bug in this. I made the buffer stack allocated and 256. That should be enough and it passes all the gtests. Thanks again.
> 
> Thanks Coleen! Looks good now.

Thanks Thomas, Ioi and Gerard. I remerged with JDK-8257229: gtest death tests fail with unrecognized stderr output to make sure they still worked together.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723