RFR: 8234930: Use MAP_JIT when allocating pages for code cache on macOS [v10]

Anton Kozlov akozlov at openjdk.java.net
Tue Dec 15 17:32:01 UTC 2020


On Tue, 15 Dec 2020 15:41:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update pd_commit_memory on bsd
>
> test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp line 172:
> 
>> 170:     const size_t num_pages = 4;
>> 171:     const size_t size = num_pages * page_sz;
>> 172:     char* base = os::reserve_memory(size, !ExecMem, mtTest);
> 
> This test function seems to leak this reservation. I leave it up to you if you want to fix it, has nothing to do with your test. If you don't could you please open a issue for this? 
> 
> (Took me some minutes to figure out that all these tests are NMT related)

Right. Tracked in https://bugs.openjdk.java.net/browse/JDK-8258415, probably it's worth review tests for similar issues

-------------

PR: https://git.openjdk.java.net/jdk/pull/294


More information about the hotspot-dev mailing list