Integrated: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest

[Coleen Phillimore]

On Wed, 9 Dec 2020 21:47:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug.  This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct).  There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.
> 
> Tested with tier1-3 with product and fastdebug builds.  Built with optimized.
> 
> This is for JDK 17.

This pull request has now been integrated.

Changeset: c37eabe7
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c37eabe7
Stats:     361 lines in 18 files changed: 145 ins; 171 del; 45 mod

8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest

Reviewed-by: iklam, stuefe

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723